Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust cursor position when on selection collapse for RTL direction #5567

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Adjust cursor position when on selection collapse for RTL direction #5567

merged 3 commits into from
Nov 30, 2023

Conversation

timagixe
Copy link
Contributor

@timagixe timagixe commented Nov 26, 2023 •
edited
Loading

Description
This PR fixes cursor position when selection is collapsed for RTL direction text.

Issue
Fixes: #5566

Example
For old behaviour please refer to issue #5566. The new behaviour video is attached below:

Screen.Recording.2023-11-26.at.3.10.32.PM.online-video-cutter.com.mp4

Context
N/A

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 26, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 4c844e4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dylans
dylans approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@dylans dylans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, thanks!

@dylans dylans merged commit 07f59e3 into ianstormtaylor:main Nov 30, 2023
10 of 11 checks passed
This was referenced Nov 30, 2023
Merged
Open
@bamboo5-dot bamboo5-dot mentioned this pull request May 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylans dylans dylans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong cursor position after Shift + Arrow Left (or Right) selection for RTL direction
2 participants
@timagixe @dylans